Fix nix edit#10814
Merged
Merged
Conversation
FilteringSourceAccessor was not delegating getPhysicalPath to its inner accessor.
github-actions
Bot
added
with-tests
Mic92
commented
May 31, 2024
| builder = ./simple.builder.sh; | ||
| PATH = ""; | ||
| goodPath = path; | ||
| meta.position = "${__curPos.file}:${toString __curPos.line}"; |
Member
Author
There was a problem hiding this comment.
I also saw that we didn't meta.position anywhere.
13 tasks
roberth
reviewed
May 31, 2024
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
LGTM, but I don't think tests/functional/flakes/flake.nix is needed.
edolstra
approved these changes
May 31, 2024
roberth
approved these changes
May 31, 2024
Member
|
Thanks, this was a blazingly fast fix ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since we introduced SourceAccessor, nix edit no longer works as described in #9652
This pull requests fixes the issue and adds regression test so that we no longer have this issue in future.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.