Merged
Conversation
Fix formatting violations, update blacklist to reflect moved files. PR NixOS#10556 passed CI before the new formating rules were added, and our CI has the race condition of allowing old results, resulting in master getting broken.
github-actions
bot
added
the
store
Member
It's possible to configure branch protections such that it requires the PR to be always up to date with the target branch, if this becomes more of a problem. |
Member
|
Maybe there is a clang formatter option to not indent #ifdefs? We've never done that historically so it would reduce the diff if we start applying the formatter to existing source files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix formatting violations, update blacklist to reflect moved files.
Context
PR #10556 passed CI before the new formating rules were added, and our CI has the race condition of allowing old results, resulting in master getting broken.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.