Skip to content

patched fromTOML to fix MacOS testing#10332

Open
p01arst0rm wants to merge 1 commit intoNixOS:masterfrom
p01arst0rm:fix-macos
Open

patched fromTOML to fix MacOS testing#10332
p01arst0rm wants to merge 1 commit intoNixOS:masterfrom
p01arst0rm:fix-macos

Conversation

@p01arst0rm
Copy link
Contributor

Motivation

currently, compilation on MacOS is broken due to a known issue relating to std::result_of being removed from c++20. This PR fixes this issue by instructing TOML11 to use std::invoke_result

More information can be found via: https://stackoverflow.com/questions/75121130

@p01arst0rm p01arst0rm requested a review from edolstra as a code owner March 26, 2024 17:06
@edolstra
Copy link
Member

Hm, where do you see macOS being broken?

@p01arst0rm
Copy link
Contributor Author

has been broken in testing for me for some time. see also >> #10330

@edolstra
Copy link
Member

That's weird, it builds on GHA and Hydra.

@p01arst0rm
Copy link
Contributor Author

That's weird, it builds on GHA and Hydra.

its related to the version of boost that is running, and the use of C++20. it seems that on MacOS toml11 doesnt properly recognise its running in C++20 without the use of version.hpp, a file added later on in newer versions of toml11

@Mic92
Copy link
Member

Mic92 commented Mar 12, 2025

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

rebase

☑️ Nothing to do

Details
  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • #commits > 1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@Mic92
Copy link
Member

Mic92 commented Mar 12, 2025

@p01arst0rm is this still an issue?

@p01arst0rm
Copy link
Contributor Author

@p01arst0rm is this still an issue?

dont have access to a mac at the moment, so cant easily check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants