test: for derivation output selection with .#10316
Merged
Ericson2314 merged 3 commits intoNixOS:masterfrom Apr 3, 2024
Merged
Conversation
. issue #7236.
roberth
reviewed
Mar 27, 2024
Member
roberth
left a comment
There was a problem hiding this comment.
IIUC this is also reflected in the output symlinks.
Member
|
|
Member
|
Yeah our existing functional tests are rather unsystematic, we need to start doing something about that so we have a better idea of test coverage. |
Member
Figuring out a better categorization for test cases seems out of scope for this PR. |
roberth
approved these changes
Mar 27, 2024
Member
|
|
Contributor
Author
this is a flake only behavior though
|
Ericson2314
reviewed
Apr 2, 2024
Member
|
Thanks @dottharun! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
added test and fixes #7236
As discussed in #7236, after #6589 the command
nix build nixpkgs#libxml2.devcorrectly builds thedevoutputAlso as pointed out by @Ericson2314 Here
outputSpecifiedattribute in derivations (Nixpkgs convention) to enable this behaviorContext
outputSpecifiedattribute in Nixpkgs Heremeta.outputsToInstallattribute is used in the test because originally with nix: Respect meta.outputsToInstall, and use all outputs by default #6426outputsToInstallis given more priority that command-line argument, thats why we are testing that behaviour tooPriorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.