Create compile-commands.json with Make#10269
Merged
thufschmitt merged 2 commits intoNixOS:masterfrom Mar 21, 2024
Merged
Conversation
edolstra
reviewed
Mar 19, 2024
thufschmitt
approved these changes
Mar 20, 2024
Member
thufschmitt
left a comment
There was a problem hiding this comment.
Ooooh that is great!
Tried it locally, and it works like a charm (and generates a compilation database that's semantically equivalent to the one generated by bear).
Left a few minor comments on the form
543b343 to
83fc988
Compare
thufschmitt
approved these changes
Mar 21, 2024
Member
thufschmitt
left a comment
There was a problem hiding this comment.
One of the biggest QOL improvements for contributors (well, for me at least :D).
I've edited the hacking guide to mention it.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The language server clangd needs to know the build flags which it reads from a file
compile_commands.json("JSON Compilation Database").The contributing section of the manual suggests to create this file with
This works but I find it a little unsatisfactory because of two reasons:
beardoes not do incremental updates, rebuilding a single file will result in a single file incompile_commands.json.Context
This PR adds to build system a target to create the
compile_commands.jsonfile without any unnecessary building. I tried to follow the patterns in the existing makefiles.Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.