Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails on cachix-action if user has no install-tests cache #5173

Closed
abathur opened this issue Aug 25, 2021 · 0 comments · Fixed by #5201
Closed

CI fails on cachix-action if user has no install-tests cache #5173

abathur opened this issue Aug 25, 2021 · 0 comments · Fixed by #5201
Labels

Comments

@abathur
Copy link
Member

abathur commented Aug 25, 2021

While telling someone about the install tests @domenkozar added in #4549 and I updated in #4577, I noticed that not having cachix set up for install tests causes failures like https://github.com/matthewbauer/nix/runs/3416896499?check_suite_focus=true#step:5:12:

Binary cache matthewbauer-nix-install-tests doesn't exist or it's private. Start by visiting https://app.cachix.org and create a personal/cache auth token.

This is coming from

- uses: cachix/cachix-action@v10
with:
name: '${{ env.CACHIX_NAME }}'
signingKey: '${{ secrets.CACHIX_SIGNING_KEY }}'
authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}'

The check_cachix step I introduced in #4577 should have the right general logic for this, and I think single steps can be made conditional, so maybe the tests job can also use needs: [check_cachix], and then the cachix-action step can use if: needs.check_cachix.outputs.secret == 'true' to avoid running this step unless a credential is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant