.github: fix outdated dependencies and prevent disk filling up by splitting attributes across multiple jobs#26
Merged
Conversation
sternenseemann
force-pushed
the
ci
branch
4 times, most recently
from
f39ea4b to
0b73e95
Compare
sternenseemann
changed the title
Member
Author
|
ghcHEAD failure is solved by #25. |
maralorn
approved these changes
Jan 2, 2025
ci.nix
Outdated
| { mkDerivation, base, Cabal, Cabal-syntax, lib }: | ||
| mkDerivation { | ||
| pname = "jailbreak-cabal"; | ||
| version = "1.4"; |
Member
There was a problem hiding this comment.
Is the plan to keep this version field updated. Otherwise we might want to set it to something different.
Member
Author
There was a problem hiding this comment.
Good point, changed it to unstable-unknown
The expression doesn't differ between GHC versions (and shouldn't in the future for ease of maintenance in nixpkgs), so we can just check it in statically. The benefit of this is that CI doesn't depend on cabal2nix working for all tested GHC versions.
The runners don't have enough disk space to download all GHC versions we are testing. The solution is to run an initial job that writes a JSON list of all attributes that ci.nix exposes to a GHA output. This can then be re-used in a matrix to create one job per attribute of ci.nix. This means that the targets built in parallel on independent runners which should reduce CI time overall and solves the disk space problem. Only downside seems to be that we need to wait on the Nix installer twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.