fix fetching from remote archives#455
Merged
Conversation
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
10 tasks
Author
|
Is there anything I can do to help this get merged? |
Member
|
It would be great to have a slightly more expressive description than "fix fetching from remote archives". Ideally, the commit message should say
|
Commit 854695a removed attempting to use nix-prefetch-zip on the downloaded artifact in favor of only nix-prefetch-url, which does not unpack automatically. With that, fetching from remote archives became broken as no handler would succeed. This adds an optional `command` argument to fetchWith, with which the command to use for fetching can be specified instead of it being derived from the kind. That `command` argument is then used by the reintroduced kind `zip` to call nix-prefetch-url (with the `--unpack` flag) instead of nix-prefetch-zip. In addition, a bug where `fetchWith` would return the path of the artifact instead of the output of the handler has been fixed.
Author
|
Thank you, I amended the commit message with a detailed description of what the commit does. |
Member
|
I have tested that this works and doesn‘t break the other fetchers. petis concerns seem to be addressed. |
Member
|
Thank you @hyperfekt ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says.
Ideally a bigger rearchitecting would have been done at the point the assumption that the kind implies the command broke down (with 854695a), but I think that's beyond me.
Processing repositories may take longer than before if there is a big file at the same URL, since that is downloaded twice before even trying to use a version control client.
I did not add a test because I'm not sure how to do that in a way such that it can be disabled in nixpkgs (to remain in the build sandbox).
Closes #377.