Put file src attribute in quotes to allow more paths#402
Merged
peti merged 1 commit intoNixOS:masterfrom Jan 29, 2019
Merged
Conversation
Contributor
Author
|
@peti I'm quite sorry but this looks to be an incorrect PR:
Do you need a PR to revert this one? And sorry once again for not testing it thoroughly. |
Member
|
I'll revert the patch in #404. |
Contributor
Author
|
Great, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nix paths allow only limited set of characters thus for example paths with "@" of paths with non-latin characters give derivation with Nix fails to parse. Quoting resolves this problem.