Merged
Conversation
peti
requested changes
May 28, 2018
hackage2nix/Main.hs
Outdated
| & metaSection.hydraPlatforms %~ (`Set.difference` Map.findWithDefault Set.empty name (dontDistributePackages config)) | ||
| & metaSection.maintainers .~ Map.findWithDefault Set.empty name globalPackageMaintainers | ||
| & metaSection.hydraPlatforms %~ (if isInDefaultPackageSet then id else const Set.empty) | ||
| & metaSection.homepage .~ ("https://hackage.haskell.org/package/" ++ display pkgId) |
Member
There was a problem hiding this comment.
Please set homepage to an empty string "" instead to suppress the meta.homepage output altogether. That way, we can let the generic builder construct the appropriate URL from its default settings rather than repeating an almost identical Hackage URL several thousand times in the generated file.
ryantm
force-pushed
the
homepage
branch
2 times, most recently
from
5a0adc7 to
1be737f
Compare
Member
Author
|
@peti fixed. |
homepage will be set to Hackage by the generic builder. The hackage page is always there, and supports a TLS connection.
ryantm
changed the title
peti
approved these changes
May 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hackage page is always there, and supports a TLS connection.