Merged
Conversation
markuskowa
force-pushed
the
fix-vermouth
branch
from
eacd72d to
0cfa994
Compare
remove constraint for networkx 2.0
markuskowa
force-pushed
the
fix-vermouth
branch
from
0cfa994 to
6e9734f
Compare
Member
|
Looks good to me. If the interface is still compatible (which it apparently is in the relevant parts), I see no reason to expect a breakage. |
sheepforce
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove constraint for networkx 2.0.
networkxhas been updated to version 3.0 (NixOS/nixpkgs#218614).Both packages just build fine and polyply passes all tests.
@sheepforce can you check if that fix is okay?