Delete metadata for transient keys #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
delete-transient-metadata-clear
branch
from
8b2d3c7
to
fb6a84e
Compare
sosthene-nitrokey
force-pushed
the
delete-transient-metadata-clear
branch
from
1d235c8
to
9097bb0
Compare
This requires re-generating a key on import, which is weird, I'll see if there are ways to avoid that
sosthene-nitrokey
force-pushed
the
delete-transient-metadata-clear
branch
from
9097bb0
to
22730c8
Compare
|
Ok, this is fixed, there were some challenges with private-key only imported keys (brainpool and nist curves larger than 256 bits), since the re-import would not accept not having the exact same metadata, but that should be fixed now! The full opcard test suite passes on hardware including brainpool and large nist curves now! |
robin-nitrokey
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires re-generating a key on import, which is weird, I'll see if there are ways to avoid that