-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make configure method public #31
Conversation
This method will now be called in the init process, based on the last configured version
34d04ad
to
fd3d732
Compare
This PR also replaces #29 |
For the filesystem versions we just use an integer which is easier to handle than the crate version. Would that make sense in this case too? |
We could, but that seemed less error prone. The filesystem was versioned because it batches migrations from multiple backends at the same time, and filesystem migrations are much more expensive/risky than SE050 re-configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, if you thing this is easier than let’s do it that way. For me the main argument for a counter would have been that we currently don’t always bump the crate version for every change. This is especially true for testing, but also for the regular firmware. So if you want to test changes, you need to bump the crate version every time instead of just changing a counter.
Right. it's true that we generally bump the version number only very late in the development cycle. |
Maybe the struct could also be a bitflag of configured curves. This could also make future configure calls faster, by only configuring non-configured curves. |
I’m fine with both approaches. I would default to using a counter because it is simpler, the additional work to re-initialize curves is negligible and it gives us more flexibility if we need to change the configuration more fundamentally than just adding curves. |
e8e3316
to
e239875
Compare
This method will now be called in the init process, based on the last configured version