Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused update message #583

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

mmerklinger
Copy link
Contributor

@mmerklinger mmerklinger commented Oct 29, 2024

This PR removes a message used for the two step update handling on macOS.
The PR is based on the changes in Nitrokey/nitrokey-sdk-py#49
The CI currently fails because we're on a version which doesn't contain the change yet. After a version update and a rebase everything should be fine.

Changes

  • Remove an unused update message

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Test Environment and Execution

  • OS: macOS 15
  • device's model:
  • device's firmware version:

Relevant Output Example

Fixes #

@mmerklinger mmerklinger self-assigned this Oct 29, 2024
@mmerklinger mmerklinger marked this pull request as draft October 29, 2024 09:32
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wait with this change until we need to bump the minimum SDK version for some other reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants