Require authentication for partial restore #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerklinger
force-pushed
the
nethsm-partial-restore-authentication
branch
2 times, most recently
from
c2c9e25
to
cc4cdf1
Compare
|
This includes now latest nethsm-sdk-py and can be reviewed. |
robin-nitrokey
approved these changes
Jul 31, 2024
robin-nitrokey
requested changes
Jul 31, 2024
pynitrokey/cli/nethsm.py
Outdated
Comment on lines
1420
to
1453
| if state == State.UNPROVISIONED: | ||
| require_auth = False | ||
| elif state == State.OPERATIONAL: | ||
| require_auth = True |
There was a problem hiding this comment.
what happens in the else case? maybe just check for one of the two states, or directly raise an exception
There was a problem hiding this comment.
I change this to have a default to require_auth = False. Only the state Operational will change this. Otherwise the error is handled by the SDK, with error message from the NetHSM.
mmerklinger
force-pushed
the
nethsm-partial-restore-authentication
branch
from
fb56e31
to
0a1d765
Compare
I tested it with the latest container, but feel free to test if you want. |
robin-nitrokey
approved these changes
Jul 31, 2024
robin-nitrokey
force-pushed
the
nethsm-partial-restore-authentication
branch
from
0a1d765
to
f526fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check for the NetHSM restore command, to determine if the authentication is required based on the state. Also raises the version for nethsm-sdk-py.
Depends on Nitrokey/nethsm-sdk-py#124
Changes
1.2.1.Checklist
Make sure to run
make checkandmake fixbefore creating a PR, otherwise the CI will fail.Test Environment and Execution
Relevant Output Example
Fixes #