Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nethsm: Add support for namespaces #535

Merged
merged 1 commit into from
Jul 17, 2024
Merged

nethsm: Add support for namespaces #535

merged 1 commit into from
Jul 17, 2024

Conversation

robin-nitrokey
Copy link
Member

@robin-nitrokey robin-nitrokey marked this pull request as ready for review July 17, 2024 14:19
sosthene-nitrokey
sosthene-nitrokey approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is related to nitropy and should block this PR, but is it expected that with the namespaces prefix and prefixsomething, deleting the prefix namespace deletes both namespaces?

@robin-nitrokey
Copy link
Member Author

Good catch, thank you! Reported upstream. I’ll merge this anyway as the fix should not affect the API.

@robin-nitrokey robin-nitrokey merged commit 1d33350 into master Jul 17, 2024
8 checks passed
@robin-nitrokey robin-nitrokey deleted the nethsm-namespaces branch July 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosthene-nitrokey sosthene-nitrokey sosthene-nitrokey approved these changes

@daringer daringer Awaiting requested review from daringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robin-nitrokey @sosthene-nitrokey