Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update urllib3 to >=2.0,<2.1; #441

Merged
merged 1 commit into from
Sep 20, 2023
Merged

update urllib3 to >=2.0,<2.1; #441

merged 1 commit into from
Sep 20, 2023
+1 −1

Conversation

daringer
Copy link
Collaborator

updated urllib3 to >=2.0 <2.1
nethsm to be tested @nponsard - can you take a look please ?

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.11
  • signed commits

Test Environment and Execution

  • OS: Arch
  • device's model: n/a
  • device's firmware version: n/a

Fixes #426

nponsard
nponsard approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nponsard nponsard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests to the NetHSM are still working, I did not test every endpoint but the request I tried work (one of each method, GET,POST,PUT,DELETE)

@daringer daringer merged commit a993db6 into master Sep 20, 2023
10 checks passed
@daringer daringer deleted the urllib3-upd branch September 20, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nponsard nponsard nponsard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

urllib3 v2 support
2 participants
@daringer @nponsard