nk3 test: Fix provisioner test #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the provisioner test to the default excludes for the nitropy nk3 test command. The reason for this is that it the test is not relevant outside of production and is likely to fail if gnupg/scdaemon is running or if there is an issue with pcscd. It also changes the test setup so that the provisioner test case is always listed, even if pyscard is not installed. In this case, it is marked as skipped. Fixes #323
daringer
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the provisioner test to the default excludes for the nitropy nk3 test command. The reason for this is that it the test is not relevant outside of production and is likely to fail if gnupg/scdaemon is running or if there is an issue with pcscd.
It also changes the test setup so that the provisioner test case is always listed, even if pyscard is not installed. In this case, it is marked as skipped.
Fixes #323
Changes
nitropy nk3 test.pyscardis missing.Checklist
Test Environment and Execution
Relevant Output Example