fido2 list-credentials: Handle missing RP name #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RP name is optional when enumerating RPs using the credential management command. Only the id is required. This patch changes the fido2 list-credentials subcommand to show the id instead of the name if the name is not set. Fixes: #352
robin-nitrokey
added
device/Nitrokey FIDO2
szszszsz
approved these changes
May 10, 2023
szszszsz
reviewed
May 10, 2023
pynitrokey/cli/fido2.py
Outdated
Comment on lines
239
to
242
| if "name" in reliable_party: | ||
| local_print(f"{reliable_party['name']}: ") | ||
| else: | ||
| local_print(f"{reliable_party['id']}: ") |
There was a problem hiding this comment.
Could be better with:
Suggested change
| if "name" in reliable_party: | |
| local_print(f"{reliable_party['name']}: ") | |
| else: | |
| local_print(f"{reliable_party['id']}: ") | |
| name = reliable_party.get('name', reliable_party['id']) | |
| local_print(f"{name}: ") |
szszszsz
requested changes
May 10, 2023
|
Tested on NK3C v1.3.1 and NK FIDO2 2.4.0. |
szszszsz
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RP name is optional when enumerating RPs using the credential management command. Only the id is required. This patch changes the fido2 list-credentials subcommand to show the id instead of the name if the name is not set.
Fixes: #352
Checklist
make checkormake fixfor the formatting checkTest Environment and Execution