Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fix reformats, with Python set to 39 #304

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

szszszsz
Copy link
Member

This PR updates the rules to use Python 3.9. The "35" used until now is not available in the latest black/isort releases, thus fail on the new setups.

Changes

  • update black to 39
  • update isort to 39

Checklist

  • tested with Python3.10
  • run make check or make fix for the formatting check
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I already wondered why the dataclass import is misplaced …

@click.option(
"--force-restart",
is_flag=True,
help="Force pcscd and GnuPG services restart once finished",
)
def set_identity(identity, force_restart):
def set_identity(identity):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you maybe want to push this commit to #305?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks so indeed. Will look into that during the merge, good spot!

@szszszsz szszszsz merged commit d097213 into master Dec 29, 2022
@szszszsz szszszsz deleted the update-black-isort-to-p39 branch December 29, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants