Correct Nitrokey FIDO2 update #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check available firmware before downloading Require --force switch if current firmware is up-to-date Visual reformat of the messages
Connected: #171
|
I’ll have a closer look later, but what do you think about using the |
|
Sure! I am all in favor of it. This is just a quick correction of the current state - surely could be refactored and unified across devices. |
|
Just to add: since it has adds some value from the user POV I propose not delay it more, and push it out as it is as long as it does not break anything or violate any rules, and plan the further refactor later. |
robin-nitrokey
approved these changes
Feb 8, 2022
daringer
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct Nitrokey FIDO2 update
Tested on Fedora 34, with market version of Nitrokey FIDO2.