Add Nitrokey 3 support to readme #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch mentions the Nitrokey 3 in the readme and adds a link to its documentation on docs.nitrokey.com.
szszszsz
approved these changes
Dec 9, 2021
robin-nitrokey
added a commit
to robin-nitrokey/pynitrokey
that referenced
this pull request
Jan 21, 2022
This patch updates the nethsm csr subcommand to support generating CSR both for the HTTPS API and for keys stored on the NetHSM. Note that the CSR generation for a specific key currently does not work due to NetHSM issue Nitrokey#115, but this is expected to be fixed soon.
robin-nitrokey
added a commit
to robin-nitrokey/pynitrokey
that referenced
this pull request
Jan 21, 2022
Due to NetHSM issue Nitrokey#115, the generated API client does not work for the /keys/{key_id}/csr.pem endpoint. Therefore, this patch replaces the generated code with a manual implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch mentions the Nitrokey 3 in the readme and adds a link to its
documentation on docs.nitrokey.com.