Skip to content

Commit

Permalink
Remove --experimental switch requirement for Nitrokey 3 update under …
Browse files Browse the repository at this point in the history
…MS Windows

Fixes #203
  • Loading branch information
szszszsz committed Mar 10, 2022
1 parent d4a7dda commit d1a23fd
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions pynitrokey/cli/nk3/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ def validate_update(image: str) -> None:
default=False,
is_flag=True,
help="Allow to execute experimental features",
hidden=True,
)
@click.pass_obj
def update(ctx: Context, image: Optional[str], experimental: bool) -> None:
Expand All @@ -315,16 +316,10 @@ def update(ctx: Context, image: Optional[str], experimental: bool) -> None:
If the connected Nitrokey 3 device is in firmware mode, the user is prompted to touch the
device’s button to confirm rebooting to bootloader mode.
This feature is experimental on MS Windows.
"""

if platform.system() == "Windows" and not experimental:
raise CliException(
"We experience some issues with this operation on Windows. "
"If possible please run it on another operating system or wait for the further updates. "
"Please pass --experimental switch to force running it anyway."
)
if experimental:
"The --experimental switch is not required to run this command anymore and can be safely removed."

with ctx.connect() as device:
release_version = None
Expand Down

0 comments on commit d1a23fd

Please sign in to comment.