Add dangerous-test-real-card feature to run the tests on a real card. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is labeled as dangerous as it will wipe the pgp smartcard plugged in. This feature only affects tests and is incompatible with --virtual
|
What do you think about adding an environment valuable that is used to store the serial number of the smartcard to test? If it does not match the connected card, the tests are aborted. This would ensure that they are not accidentally executed with a production smartcard. |
|
Good idea! We still need the feature flag to remove the |
robin-nitrokey
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is labeled as dangerous as it will wipe the pgp smartcard plugged in. This feature only affects tests and is incompatible with --virtual