Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RESET RETRY COUNTER #63

Merged
merged 8 commits into from
Oct 17, 2022
Merged

Implement RESET RETRY COUNTER #63

merged 8 commits into from
Oct 17, 2022

Conversation

sosthene-nitrokey
Copy link
Collaborator

No description provided.

@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Oct 4, 2022
Open
23 tasks
robin-nitrokey
robin-nitrokey reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, but please have a look at the two comments regarding the PIN length check and initializing the reset counter.

src/command.rs Outdated Show resolved Hide resolved
src/command.rs Show resolved Hide resolved
src/command/data.rs Outdated Show resolved Hide resolved
src/state.rs Show resolved Hide resolved
@robin-nitrokey robin-nitrokey merged commit fe66643 into main Oct 17, 2022
@robin-nitrokey robin-nitrokey deleted the reset-retry-counter branch October 17, 2022 13:18
robin-nitrokey added a commit that referenced this pull request Oct 17, 2022
@robin-nitrokey
Update changelog for recent PRs
1fa4b9e 
This patch updates the changelog for the PRs #63 and #76.
@robin-nitrokey robin-nitrokey mentioned this pull request Oct 17, 2022
Merged
@robin-nitrokey robin-nitrokey added this to the v0.2.0 milestone Oct 17, 2022
@robin-nitrokey robin-nitrokey mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @robin-nitrokey