Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RSA key size support a runtime configuration #190

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Make RSA key size support a runtime configuration #190

merged 2 commits into from
Nov 24, 2023

Conversation

sosthene-nitrokey
Copy link
Collaborator

This will enable us to allow RSA 4096 bit key generation when the se050 backend is enabled.

robin-nitrokey
robin-nitrokey reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add max(imum) to the field and method names for clarity, i. e. default_max_gen, default_max_import, rsa_max_gen, rsa_max_import.

@sosthene-nitrokey sosthene-nitrokey merged commit 1b3e194 into main Nov 24, 2023
1 check was pending
@sosthene-nitrokey sosthene-nitrokey deleted the rsa-runtime-config-main branch November 24, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

@daringer daringer Awaiting requested review from daringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @robin-nitrokey