Add RSA 3072 bits tests #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also feature-gate key generation like we do for RSA4096? A full key generation takes around 15 minutes. |
sosthene-nitrokey
force-pushed
the
rsa3072-tests
branch
from
5695836
to
0dc48b2
Compare
|
It would not be a lot of effort to add the feature, right? In that case I’d like to add it now so that we don’t have to make a new release if we decide to change it. |
sosthene-nitrokey
force-pushed
the
rsa3072-tests
branch
from
a2336f7
to
8ebcce8
Compare
sosthene-nitrokey
force-pushed
the
rsa3072-tests
branch
from
8ebcce8
to
5b09971
Compare
robin-nitrokey
approved these changes
Apr 24, 2023
sosthene-nitrokey
force-pushed
the
rsa3072-tests
branch
from
5b09971
to
e8146d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.