Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt user keys #137

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Encrypt user keys #137

merged 1 commit into from
Apr 11, 2023

Conversation

sosthene-nitrokey
Copy link
Collaborator

No description provided.

@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Apr 11, 2023
Closed
robin-nitrokey
robin-nitrokey approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to replace tuples like (KeyId, KeyOrigin) and (KeyId, KeyId) with structs like PublicKeyInfo and KeyPair but that’s not a blocker.

@robin-nitrokey robin-nitrokey merged commit d185d6e into data-encryption Apr 11, 2023
@robin-nitrokey robin-nitrokey deleted the key-encryption branch April 11, 2023 20:01
@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Apr 12, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @robin-nitrokey