Rename "virtual" to "vpicc" #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
approved these changes
Apr 6, 2023
README.md
Outdated
Comment on lines
44
to
45
| Opcard uses [virtualsmartcard](https://frankmorgner.github.io/vsmartcard/) for testing. | ||
| `make test` will run `opcard` on the host through virtualsmartcard and test it. | ||
| Opcard uses [vpiccsmartcard](https://frankmorgner.github.io/vsmartcard/) for testing. | ||
| `make test` will run `opcard` on the host through vpiccsmartcard and test it. |
There was a problem hiding this comment.
I’d either use vsmartcard (= the entire project) or vpicc (= the specific Rust crate) here (or maybe both)?
There was a problem hiding this comment.
I used search and replace and then checked which replacements were incorrect and missed this.
sosthene-nitrokey
force-pushed
the
virtual-vpicc
branch
from
7e172d0
to
390736f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #131