Migrate RSA support to trussed-rsa-backend
#116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
rsa-backend
branch
from
64e71ae
to
7e3225d
Compare
robin-nitrokey
approved these changes
Feb 10, 2023
| rsa2048 = ["trussed/rsa2048"] | ||
| rsa4096 = ["rsa2048", "trussed/rsa4096"] | ||
| rsa = ["trussed-rsa-backend"] | ||
| rsa2048 = ["rsa"] |
There was a problem hiding this comment.
Do we still need this as a separate feature?
There was a problem hiding this comment.
It still requires an allocator AKA nightly. It also doesn't solve the problem of slow key generation which means we still need the feature flag for RSA 4096 key generation. I also need to test how long it takes for RSA-3072
sosthene-nitrokey
force-pushed
the
rsa-backend
branch
from
3001a6f
to
e89a35a
Compare
sosthene-nitrokey
force-pushed
the
rsa-backend
branch
from
e89a35a
to
ce7b545
Compare
sosthene-nitrokey
force-pushed
the
rsa-backend
branch
from
ce7b545
to
e50dec4
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.