Add usbip runner example and test against the Gnuk test suite #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
usbip-runner
branch
from
9917456
to
b9c0507
Compare
|
Unlike Nitrokey/nitrokey-3-firmware#149, the example is detected by |
Cargo.toml
Outdated
| @@ -50,6 +54,10 @@ ron = "0.8" | |||
| serde_cbor = "0.11" | |||
| hex = { version = "0.4", features = ["serde"] } | |||
|
|
|||
| # usbip | |||
| trussed-usbip = { git = "https://github.com/trussed-dev/pc-usbip-runner", default-features = false, features = ["ccid"]} | |||
There was a problem hiding this comment.
Add a rev until we have a first release?
sosthene-nitrokey
force-pushed
the
usbip-runner
branch
from
d96bdc4
to
0070f96
Compare
sosthene-nitrokey
changed the title
|
This PR is becoming a bit more than just the example, I also add to it fixes I find by testing against the Gnuk test suite. I will break it down into multiple PRs. I actually also needed to modify the test suite to adapt to some variation in behavior that are not bugs (supported algos for example). I'll create a fork of it, we can try to upstream the changes once everything looks good. |
sosthene-nitrokey
force-pushed
the
usbip-runner
branch
3 times, most recently
from
0ad657a
to
cf06b17
Compare
sosthene-nitrokey
force-pushed
the
usbip-runner
branch
from
cf06b17
to
e82c9e5
Compare
|
Updated to work on top of the latest main. The bugs I talk about were fixed in other PR, this tree actually passes the test suite. |
robin-nitrokey
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.