Allow gpg to run factory-reset when the state is corrupted #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
corrupted-state-gpg
branch
from
cdee438
to
c20b631
Compare
robin-nitrokey
approved these changes
Jan 3, 2023
src/command/data.rs
Outdated
| } else { | ||
| // If the state doesn't load, return placeholder so that gpg presents the option to factory reset | ||
| ctx.reply | ||
| .expand(b"Card state corrupted. Factory reset recommended") |
There was a problem hiding this comment.
I would remove the second sentence because I’d prefer people telling us in support if they run into this issue. We could still document it in the release notes, but if this happens in a different context, I’d like to know.
There was a problem hiding this comment.
Should I recommend them to open an issue ? The limit is 39 characters so I don't think we can put a link.
There was a problem hiding this comment.
We could use the URL DO for that
There was a problem hiding this comment.
The limit at 39 characters doesn't seem to be an issue with GPG.
sosthene-nitrokey
force-pushed
the
corrupted-state-gpg
branch
from
352fc85
to
c51db89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some
GET DATAcommands return placeholder data when the state is corrupted. That way the card can still be factory reset even if the state fails to load. This avoids having to send raw commends as we recommend in the second alpha release notes.When the state is corrupted, the card puts as a placeholder name:
Card state corrupted. Factory reset recommended, sogpg --card-statuslooks like: