Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency overrides #101

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Update dependency overrides #101

merged 1 commit into from
Jan 2, 2023

Conversation

robin-nitrokey
Copy link
Member

@robin-nitrokey robin-nitrokey commented Dec 21, 2022

This patch updates the dependency overrides for consistency with nitrokey-3-firmware, see:
https://github.com/Nitrokey/nitrokey-3-firmware/blob/main/Cargo.toml
This has multiple benefits:

  • By using tags instead of branch names, we are sure to operate on the same versions, even without a Cargo.lock file.
  • It is easier to keep track of the currently used versions.
  • We don’t risk to get out of sync with the actual firmware.

(As a side effect, this fixes an issue with the virtual trussed platform and the latest nightly Rust compiler.)

This patch updates the dependency overrides for consistency with
nitrokey-3-firmware, see:
	https://github.com/Nitrokey/nitrokey-3-firmware/blob/main/Cargo.toml
This has multiple benefits:
- By using tags instead of branch names, we are sure to operate on the
  same versions, even without a `Cargo.lock` file.
- It is easier to keep track of the currently used versions.
- We don’t risk to get out of sync with the actual firmware.
Copy link
Collaborator

@sosthene-nitrokey sosthene-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robin-nitrokey robin-nitrokey merged commit 77133a9 into main Jan 2, 2023
@robin-nitrokey robin-nitrokey deleted the patch-tags branch January 2, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants