Docker build #103
Merged
Docker build #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LennardBoediger
force-pushed
the
docker-build
branch
from
505d2bd to
2c8cc5f
Compare
szszszsz
reviewed
May 25, 2021
Dockerfile
Outdated
| # COPY avr32studio-ide-2.6.0 | ||
| ARG TOOLCHAIN_LINK=https://cloud.nitrokey.com/s/a4Z2abXRjjYEzDJ/download | ||
| RUN cd / && wget ${TOOLCHAIN_LINK} -O toolchain.zip -q && \ | ||
| unzip toolchain.zip && \ |
There was a problem hiding this comment.
Can we make unzip silent? It clutters the view.
LennardBoediger
force-pushed
the
docker-build
branch
3 times, most recently
from
960b1d6 to
555da4e
Compare
|
Hi! Let me know once you are ready. Can you switch to draft in the meantime? |
LennardBoediger
force-pushed
the
docker-build
branch
from
fae1caa to
fd1a119
Compare
|
it should be ready to be merged, but there are some server issues that prevent me from doing the final test, so still on hold |
|
ready to merge |
|
Hi! I see you are still changing the PR. Let me know once done! |
LennardBoediger
force-pushed
the
docker-build
branch
from
7b4fd13 to
19fff03
Compare
LennardBoediger
force-pushed
the
docker-build
branch
from
5b68dd6 to
3cb0f65
Compare
LennardBoediger
force-pushed
the
docker-build
branch
from
ca7f5d5 to
1bd6ea7
Compare
|
the artifacts path was wrong - now it is really ready to merge |
szszszsz
approved these changes
Jun 8, 2021
| - make docker-make | ||
| after_script: | ||
| - cp ./src/*.hex artifacts | ||
| - wget 188.40.174.112:8089/checkmark/$CI_COMMIT_REF_NAME/$CI_COMMIT_SHA/$CI_JOB_NAME/$CI_JOB_STATUS/${CI_JOB_URL#*/*/*/} |
There was a problem hiding this comment.
Is this IP documented somewhere? Why IP instead of a domain (not futureproof, as IPs are changing)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all test passed
https://git.dotplex.com/nitrokey/nitrokey-storage-firmware/-/pipelines