Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding installation method for mac via pipenv #346

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

adding installation method for mac via pipenv #346

wants to merge 4 commits into from

Conversation

nitrosimon
Copy link
Collaborator

@nitrosimon nitrosimon commented Dec 4, 2024 •
edited
Loading

fixes #341

@nitrosimon
Copy link
Collaborator Author

nitrosimon commented Dec 11, 2024 •
edited
Loading

fixes #341

@nitrosimon nitrosimon requested a review from daringer January 11, 2025 18:00
jans23
jans23 reviewed Jan 14, 2025
View reviewed changes
source/components/software/nk-app2/installation_mac.rst
Pipenv
------

This is the simplest way for now to install the Nitrokey App 2 on Mac. Further methods are being worked on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "macOS"

jans23
jans23 reviewed Jan 14, 2025
View reviewed changes
source/components/software/nk-app2/installation_mac.rst
@@ -0,0 +1,39 @@
Mac Install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "macOS"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, but this is wrong multiple times in the documentation , ill make a new issue for fixing this in the whole documentation overall

jans23
jans23 reviewed Jan 14, 2025
View reviewed changes
source/components/software/nk-app2/installation_mac.rst
cd nitrokeyapp
2. pipenv update

To run the application, go into the workdirectory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"work directory"

jans23
jans23 reviewed Jan 14, 2025
View reviewed changes
source/components/software/nk-app2/installation_mac.rst
To run the application, go into the workdirectory
::

cd nitrokeyapp and run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jans23 jans23 jans23 left review comments

@daringer daringer Awaiting requested review from daringer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document NitrokeyApp2 install method for Mac
3 participants
@nitrosimon @jans23 @daringer