-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Nitrokey Python SDK #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
sdk
branch
3 times, most recently
from
July 30, 2024 15:14
ec1ef28
to
98cd4af
Compare
All relevant components of pynitrokey have been moved to the Nitrokey Python SDK or can be replaced by the fido2 library. The last missing piece, Retries, is so simple that we can just copy it into this package. So we can now remove the pynitrokey dependency.
daringer
force-pushed
the
sdk
branch
2 times, most recently
from
August 27, 2024 09:12
5e59697
to
c3cff44
Compare
looks good with nitrokey-sdk v0.2rc1 - waiting for this to release, then follow with this PR |
Linux (Fedora 40, Python 3.9)
|
Windows (10 Professional, Python 3.11.9)
|
I think the issues above with the PIN setting I saw before mentioned by a user, so probably a different bug and has nothing to do with this specific branch. |
okok, I guess this is good news, reset + pin needs further work anyways and shouldn't block this - nice! |
mmerklinger
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces the pynitrokey dependency with the Nitrokey Python SDK. For FIDO2 interactions, the fido2 library can be used directly.
Retries
is so simple that it can be copied from pynitrokey.