Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nitrokey Python SDK #264

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Use Nitrokey Python SDK #264

merged 4 commits into from
Sep 3, 2024

Conversation

robin-nitrokey
Copy link
Member

This patch replaces the pynitrokey dependency with the Nitrokey Python SDK. For FIDO2 interactions, the fido2 library can be used directly. Retries is so simple that it can be copied from pynitrokey.

All relevant components of pynitrokey have been moved to the Nitrokey
Python SDK or can be replaced by the fido2 library.  The last missing
piece, Retries, is so simple that we can just copy it into this package.
So we can now remove the pynitrokey dependency.
@daringer daringer marked this pull request as ready for review August 27, 2024 10:41
@daringer daringer marked this pull request as draft August 27, 2024 10:41
@daringer
Copy link
Collaborator

looks good with nitrokey-sdk v0.2rc1 - waiting for this to release, then follow with this PR

@mmerklinger
Copy link
Collaborator

Linux (Fedora 40, Python 3.9)

NRF52 LPC55
Update Ok Ok
Add passwords Ok Ok
Change PINs Doesn't work. Gives weird messages about PIN requirement. Doesn't work. Gives weird messages about PIN requirement.
Reset Apps Passwords work. Fido2 reset is stuck in a reset loop until the 10 seconds timeout. Passwords work. Fido2 reset is stuck in a reset loop until the 10 seconds timeout, but it seems to work.

@mmerklinger
Copy link
Collaborator

Windows (10 Professional, Python 3.11.9)

NRF52 LPC55
Update Ok Ok
Add passwords Ok Ok
Change PINs Doesn't work. Gives weird messages about PIN requirement. Doesn't work. Gives weird messages about PIN requirement.
Reset Apps Passwords work. Fido2 reset is stuck in a reset loop until the 10 seconds timeout. Passwords work. Fido2 is stuck in a reset loop until the 10 seconds timeout, but it seems to work.

@mmerklinger
Copy link
Collaborator

I think the issues above with the PIN setting I saw before mentioned by a user, so probably a different bug and has nothing to do with this specific branch.

@daringer
Copy link
Collaborator

daringer commented Sep 3, 2024

okok, I guess this is good news, reset + pin needs further work anyways and shouldn't block this - nice!

@daringer daringer marked this pull request as ready for review September 3, 2024 09:02
@daringer daringer merged commit 09ab1a3 into main Sep 3, 2024
10 checks passed
@daringer daringer deleted the sdk branch September 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants