Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close more options #229

Merged
merged 1 commit into from
Apr 12, 2024
Merged

close more options #229

merged 1 commit into from
Apr 12, 2024

Conversation

jj-so
Copy link
Contributor

@jj-so jj-so commented Mar 28, 2024

close more options when it is open and another Nitrokey is plugged in.
#225

@jj-so jj-so added this to the v2.3.0 milestone Mar 28, 2024
@jj-so jj-so removed this from the v2.3.0 milestone Mar 28, 2024
@daringer
Copy link
Collaborator

  • move collapse from QtMixin class into Overview class
  • rewrite collapse and show_more_options to directly trigger open or collapsed: hide_more_options + show_more_options

@daringer
Copy link
Collaborator

lgtm

@jj-so jj-so merged commit 1eacc59 into main Apr 12, 2024
10 checks passed
@jj-so jj-so deleted the close_more-options branch April 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daringer daringer daringer approved these changes

@mmerklinger mmerklinger Awaiting requested review from mmerklinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jj-so @daringer