Fix/catch device removal error from fido2 lib #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitrokey3Device.list()
and the underlying fido2-library is very flaky during connect/disconnect operations and a regular error thrower, thus after trying with catching onlyOSError
the newly found issue involves a thrownException
🙄So this PR catches all
Exception
s thrown by it and cancels theremove_device
operation, which is anyways triggered multiple times so canceling the "bad" ones is fine here.