Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount EFS only once #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mount EFS only once #489

wants to merge 1 commit into from

Conversation

robin-nitrokey
Copy link
Member

With this patch, the EFS is only mounted once if it is mountable. This significantly reduces bootup time by approximately 0.5 s.

Fixes: #440

@nitrokey-ci
Copy link
Collaborator

nitrokey-ci commented Apr 24, 2024

No significant changes.

Insignifcant changes
metric value change
binary-size-nk3am 1423193 -77 (-0.00%)
binary-size-nk3am-test 2021814 -360 (-0.00%)
binary-size-nk3xn 510336 🔴 +64 (+0.00%)
binary-size-nk3xn-test 547220 🔴 +64 (+0.00%)
binary-size-nkpk 736434 🔴 +13 (+0.00%)

With this patch, the EFS is only mounted once if it is mountable.  This
significantly reduces bootup time by approximately 0.5 s.

Fixes: #440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid is_mountable calls
4 participants