Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve se050 constants inlining #476

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Improve se050 constants inlining #476

merged 1 commit into from
Apr 11, 2024

Conversation

sosthene-nitrokey
Copy link
Collaborator

@nitrokey-ci
Copy link
Collaborator

nitrokey-ci commented Apr 10, 2024 •
edited
Loading

No significant changes.

Insignifcant changes
metric value change
binary-size-nk3am 1194637 ✅ -45 (-0.00%)
binary-size-nk3am-test 2009107 ✅ -9692 (-0.00%)
binary-size-nk3xn 429864 ⚪ +0 (+0.00%)
binary-size-nk3xn-test 543228 ✅ -3392 (-0.01%)
binary-size-nkpk 731876 ⚪ +0 (+0.00%)

@sosthene-nitrokey
Copy link
Collaborator Author

Not as good as I hoped, but 1% is still good to take

@sosthene-nitrokey sosthene-nitrokey merged commit 0756683 into main Apr 11, 2024
9 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the constants-inlining branch April 11, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sosthene-nitrokey @nitrokey-ci @robin-nitrokey