Use feature-complete SE050 backend #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
se050-backend
branch
from
f0f261d
to
c8f8dc9
Compare
sosthene-nitrokey
force-pushed
the
se050-backend
branch
from
c8f8dc9
to
f363fc2
Compare
sosthene-nitrokey
force-pushed
the
se050-backend
branch
from
feb94ba
to
1a19d29
Compare
|
It doesn't yet supports RSA 4096 bit key generation when the SE050 backend is enabled. We will need to make it a runtime flag for that to work. |
sosthene-nitrokey
force-pushed
the
se050-backend
branch
3 times, most recently
from
b7f968f
to
a0c7d47
Compare
robin-nitrokey
approved these changes
Dec 1, 2023
| request, | ||
| resources, | ||
| ) | ||
| } | ||
| Extension::Se050Manage => ExtensionImpl::< |
There was a problem hiding this comment.
Not now, but for the future: We should rename this to *Info or *Test so that we don’t use the same name for two different things.
Comment on lines
49
to
+52
| "fido" => self.fido.field(key), | ||
| "opcard" => self.opcard.field(key), |
There was a problem hiding this comment.
for the future: we should try to always use App::CLIENT_ID in the Config implementations
components/apps/src/lib.rs
Outdated
| #[derive(Debug, Default, PartialEq, Deserialize, Serialize)] | ||
| pub struct OpcardConfig { | ||
| #[cfg(feature = "se050")] | ||
| #[serde(default, rename = "t", skip_serializing_if = "is_default")] |
There was a problem hiding this comment.
nit: maybe use s instead of t for the rename to keep at least some connection between the key and the field? or maybe we should just assign numbers …
components/apps/Cargo.toml
Outdated
| se050-test-app = ["se050", "admin-app/se050"] | ||
| se050 = ["trussed-se050-backend", "dep:se05x"] | ||
| se050 = ["dep:se05x", "trussed-se050-backend"] |
There was a problem hiding this comment.
My understanding was that we can keep the test app, can’t we?
sosthene-nitrokey
force-pushed
the
se050-backend
branch
from
a0c7d47
to
7b50110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
Clearapi opcard-rs#187