docs: Update storage overview #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the storage overview for secrets-app and trussed-auth.
szszszsz
approved these changes
Apr 20, 2023
|
|
||
| ### secrets-app | ||
|
|
||
| secrets-app stores the user data on the external filesystem. It uses trussed-auth for one PIN with a derived key. |
There was a problem hiding this comment.
Might be useful to explicitly tell it does not use permanent key store, and mention encryption types:
Suggested change
| secrets-app stores the user data on the external filesystem. It uses trussed-auth for one PIN with a derived key. | |
| secrets-app stores the user data on the external filesystem. Keeps no data in the permanent Trussed key store. It uses trussed-auth for one PIN with a salt for the derived key. | |
| User data are encrypted either with Hardware or PIN-based encryption key. |
|
Can we merge this, w/ or w/o the suggestion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the storage overview for secrets-app and trussed-auth.