Return correct error variants for API errors #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
errors
branch
from
e8b3047
to
7a6732a
Compare
Previously, the generated code did not properly take into account the HTTP status of error responses. We would either return *Error::UnknownError (if the response message was set) or a serde error otherwise. With this patch, we map the status codes to the corresponding error variants and skip deserialization if the response body is empty. Fixes: #30
robin-nitrokey
force-pushed
the
errors
branch
from
7a6732a
to
246825a
Compare
daringer
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the generated code did not properly take into account the HTTP status of error responses. We would either return *Error::UnknownError (if the response message was set) or a serde error otherwise.
With this patch, we map the status codes to the corresponding error variants and skip deserialization if the response body is empty.
Fixes: #30