Fix return type for get_key_certificate #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
get-key-certificate
branch
from
392a66b
to
5c4ed40
Compare
#60 changed GET /keys/{KeyId}/cert to return bytes instead of a string, but get_key_certificate was not updated accordingly.
robin-nitrokey
force-pushed
the
get-key-certificate
branch
from
5c4ed40
to
16668f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 79.34% 79.47% +0.12%
==========================================
Files 779 779
Lines 13424 13426 +2
==========================================
+ Hits 10651 10670 +19
+ Misses 2773 2756 -17
☔ View full report in Codecov by Sentry. |
q-nk
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60 changed GET /keys/{KeyId}/cert to return bytes instead of a string, but get_key_certificate was not updated accordingly.