Fix certutil certificate listing #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=========================================
+ Coverage 0 90.36% +90.36%
=========================================
Files 0 31 +31
Lines 0 6642 +6642
=========================================
+ Hits 0 6002 +6002
- Misses 0 640 +640 ☔ View full report in Codecov by Sentry. |
fetch_all_keys fills a cache. This cache is expected to contain all objects, not just the kind that was first fetched.
sosthene-nitrokey
force-pushed
the
certutil
branch
from
e210413
to
1defba0
Compare
|
I tested this patch and confirmed that it can list certificates uploaded using a different mechanism, and that certutil cannot add certificates. |
sosthene-nitrokey
requested review from
ansiwen and
robin-nitrokey
and removed request for
ansiwen and
robin-nitrokey
robin-nitrokey
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 changes:
CKA_SERIAL_NUMBERattribute to certificate objects.fetch_all_keysrequest caching a subset of all objects, using only the kind that was first requested.This doesn't fix the certificate upload part of #183, but that cannot be fixed without support for certificates without associated private keys.
This does fix certificate listing with
certutilmentionned in #187.