Improve the building of the docker images and document them #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 90.72% 90.72%
=======================================
Files 31 31
Lines 6158 6158
=======================================
Hits 5587 5587
Misses 571 571 ☔ View full report in Codecov by Sentry. |
The images now listen on 8081 to not require root permissions. Since AFAIK they are built for testing/demo they should not need root. The generate scripts now use the built module and not the system installed one. The generate scripts and the images now use a compatible configuration as the top-level example.
sosthene-nitrokey
force-pushed
the
images-improvements
branch
from
1f5bbef
to
0dcdba8
Compare
robin-nitrokey
approved these changes
Jan 9, 2024
daringer
approved these changes
Jan 10, 2024
|
Merged with #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The images now listen on port 8081 to not require root permissions. Since AFAIK they are built for testing/demo they should not need this.
The generate scripts now use the built module and not the system installed one.
The generate scripts and the images now use a compatible configuration as the top-level example.