Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle time-taking commands #67

Closed
szszszsz opened this issue Oct 3, 2017 · 1 comment
Closed

Handle time-taking commands #67

szszszsz opened this issue Oct 3, 2017 · 1 comment
Labels
test

Comments

@szszszsz
Copy link
Member

szszszsz commented Oct 3, 2017

Due to limiting reading repeats to fail early and improve responsiveness long commands are not handled correctly at the moment - e.g. FACTORY_RESET. A good solution might be to inform libraries' core (from inside NitrokeyManager.h) before running such command about that fact, so it would make additional reads repeats. Alternatively just increase read delay for execution of one command should fix this too.

Regarding 7f7cfeb.
@szszszsz
Copy link
Member Author

Under tests in Nitrokey App

sgued pushed a commit to sgued/libnitrokey that referenced this issue Feb 14, 2022
@daringer
Merge pull request Nitrokey#67 from robin-nitrokey/nethsm-commands-1
3ff6439 
Add provisioning and user management for NetHSM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szszszsz