Commits on Feb 20, 2024

1. Fix error type for third invalid PIN entry …

   If the user provides a wrong PIN and the persistent or per-boot PIN
   retry counter reaches its limit, we have to return the PinBlocked
   (persistent) or PinAuthBlocked (per boot) error code instead of
   PinInvalid.  The previous implementation checked the persistent retry
   counter twice instead of checking both counters.
   
   This patch fixes this problem by using the combined State::pin_blocked
   method instead of manually checking the persistent and runtime state
   directly.
   
   It also replaces a raw subtraction when computing the remaining retries
   with a saturating sub, just to be sure.

   

   robin-nitrokey committed Feb 20, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6e9fa17
   • Browse repository at this point

   Copy the full SHA

   6e9fa17 View commit details

   Browse the repository at this point in the history