Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce credential ID size #29

Closed
robin-nitrokey opened this issue Jul 8, 2023 · 0 comments · Fixed by #32
Closed

Reduce credential ID size #29

robin-nitrokey opened this issue Jul 8, 2023 · 0 comments · Fixed by #32
Assignees
@robin-nitrokey

Comments

@robin-nitrokey
Copy link
Member

Tracking issue for: trussed-dev#37
@robin-nitrokey robin-nitrokey self-assigned this Jul 8, 2023
@robin-nitrokey robin-nitrokey mentioned this issue Jul 8, 2023
Closed
12 tasks
robin-nitrokey added a commit to robin-nitrokey/fido-authenticator that referenced this issue Jul 10, 2023
@robin-nitrokey
Reduce ID length for new credentials
ca898ab 
This patch implements the following changes to reduce the ID length for
new credentials:
- Rename the old Credential type to FullCredential and introduce a
  StrippedCredential type and a Credential enum to differentiate between
  full and reduced credential data.
- Flatten the credential data to reduce encoding overhead.
- Remove the RP id from the credential data to reduce the total length.
- Add a marker field use_short_id to FullCredential so that we don’t
  change the credential ID for existing RKs.

To do:
- Add tests for EncryptedSerializedCredential serialized length (should
  be less than 255).
- Add tests for FullCredential serialized length (should fit into one
  littlefs block).

Fixes: Nitrokey#29
robin-nitrokey added a commit to robin-nitrokey/fido-authenticator that referenced this issue Jul 10, 2023
@robin-nitrokey
Reduce ID length for new credentials
5e46fe0 
This patch implements the following changes to reduce the ID length for
new credentials:
- Rename the old Credential type to FullCredential and introduce a
  StrippedCredential type and a Credential enum to differentiate between
  full and reduced credential data.
- Flatten the credential data to reduce encoding overhead.
- Remove the RP id from the credential data to reduce the total length.
- Add a marker field use_short_id to FullCredential so that we don’t
  change the credential ID for existing RKs.

To do:
- Add tests for EncryptedSerializedCredential serialized length (should
  be less than 255).
- Add tests for FullCredential serialized length (should fit into one
  littlefs block).
- Investigate if we can remove more fields from StrippedCredential.

Fixes: Nitrokey#29
@robin-nitrokey robin-nitrokey mentioned this issue Jul 10, 2023
Merged
4 tasks
robin-nitrokey added a commit to robin-nitrokey/fido-authenticator that referenced this issue Jul 10, 2023
@robin-nitrokey
Reduce ID length for new credentials
4a9ca5c 
This patch implements the following changes to reduce the ID length for
new credentials:
- Rename the old Credential type to FullCredential and introduce a
  StrippedCredential type and a Credential enum to differentiate between
  full and reduced credential data.
- Flatten the credential data to reduce encoding overhead.
- Remove the RP id from the credential data to reduce the total length.
- Add a marker field use_short_id to FullCredential so that we don’t
  change the credential ID for existing RKs.

To do:
- Add tests for EncryptedSerializedCredential serialized length (should
  be less than 255).
- Add tests for FullCredential serialized length (should fit into one
  littlefs block).
- Investigate if we can remove more fields from StrippedCredential.

Fixes: Nitrokey#29
robin-nitrokey added a commit to robin-nitrokey/fido-authenticator that referenced this issue Jul 27, 2023
@robin-nitrokey
Reduce ID length for new credentials
10f1aaa 
This patch implements the following changes to reduce the ID length for
new credentials:
- Rename the old Credential type to FullCredential and introduce a
  StrippedCredential type and a Credential enum to differentiate between
  full and reduced credential data.
- Flatten the credential data to reduce encoding overhead.
- Remove the RP id from the credential data to reduce the total length.
- Add a marker field use_short_id to FullCredential so that we don’t
  change the credential ID for existing RKs.

To do:
- Add tests for EncryptedSerializedCredential serialized length (should
  be less than 255).
- Add tests for FullCredential serialized length (should fit into one
  littlefs block).
- Investigate if we can remove more fields from StrippedCredential.

Fixes: Nitrokey#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robin-nitrokey robin-nitrokey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce ID length for new credentials robin-nitrokey/fido-authenticator
1 participant
@robin-nitrokey