Add support for pinUvAuthProtocol(0x04) in HmacSecretInput #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deserialization of authenticatorGetAssertion requests using the hmac-secret extension as sent by e. g. python-fido2 currently fails. This patch adds some tests with the offending input.
The December 08, 2020 version of the Client to Authenticator Protocol (CTAP) specification added the pinUvAuthProtocol(0x04) field to the input data for the hmac-secret extension in the authenticatorGetAssertion command. This patch adds this new field to the HmacSecretInput struct to make it possible to parse requests using this new field. https://fidoalliance.org/specs/fido-v2.1-rd-20201208/fido-client-to-authenticator-protocol-v2.1-rd-20201208.html Fixes #1.
szszszsz
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Looks good!
Potential improvements:
- describe input data for tests (it's not immediately obvious), or
- better would be to provide the input structures in human-readable form and serialize them to CBOR (e.g. JSON string converted during tests execution to CBOR).
|
Merged upstream in trussed-dev#2. |
|
@robin-nitrokey Please check and remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted to upstream as trussed-dev#1 but duplicated here for an early release.